Discussion:
[PATCH 1/2] fat: Fix d_splice_alias() return code checking
(too old to reply)
Richard Weinberger
2014-10-19 10:39:43 UTC
Permalink
d_splice_alias() can return a valid dentry, NULL or an ERR_PTR.
Currently the code checks not for ERR_PTR.
Fix this by using IS_ERR_OR_NULL().

Cc: OGAWA Hirofumi <***@mail.parknet.co.jp>
Signed-off-by: Richard Weinberger <***@nod.at>
---
fs/fat/namei_vfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index 6df8d3d..8f93464 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -757,7 +757,7 @@ out:
mutex_unlock(&MSDOS_SB(sb)->s_lock);
dentry->d_time = dentry->d_parent->d_inode->i_version;
dentry = d_splice_alias(inode, dentry);
- if (dentry)
+ if (!IS_ERR_OR_NULL(dentry))
dentry->d_time = dentry->d_parent->d_inode->i_version;
return dentry;
--
2.1.0
Loading...